Switch tests to release-profile from dev-profile #3180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvp
force-pushed
the
test/fix-genesis-block
branch
from
7cbb714
to
f818a3e
Compare
|
@vvp can you revert the Cargo.toml spacing formatter changes? These are auto-gen'ed by our release engine. |
vvp
force-pushed
the
test/fix-genesis-block
branch
2 times, most recently
from
0ac0edd
to
c7d3d94
Compare
vvp
force-pushed
the
test/fix-genesis-block
branch
from
c7d3d94
to
cd06d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures CI to execute tests with
cargo test --releaseand fixes the tests that break when running withreleaseprofile.All failing tests fail due to
snarkVMtest-helpers generating a sample genesis block, which panics only when running inreleaseprofile (The genesis block must contain exactly 1 ratification, originated from https://github.com/AleoHQ/snarkVM/blob/mainnet-staging/ledger/block/src/header/genesis.rs#L24-L27). It might make sense to refactor theVM::genesis_beacon()-based fix over tosnarkVMtest-helpers side.In general, tests should be run on as production-like build as possible, so if
snarkVMruns its tests withdevprofile, at leastsnarkOSshould doreleasetests for appropriate coverage.