Fix SHELL using absolute path and disable duplicate profile inclusion #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This v2 of the PR. In previous version I assumed that the issue was absolute path in SHELL variabe. Leaving only the basename eliminated the hanging on start but subshell still didn't work. After doing additional testing I figured that that wasn't the issue. The issue of broekn shells seems to be related to duplicate inclusion of distrobox hooks when profile.d available. While provided patch works a more comprehensive solution might be required to cover all cases. In general we should inject hooks only once (first start or creation). Since injecting on every start prevents customization of the container by the user and can make it very difficult to identify shell/profile related issues (ask me how I know ;-))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This v2 of the PR.
In previous version I assumed that the issue was absolute path
in SHELL variabe. Leaving only the basename eliminated the hanging on start
but subshell still didn't work.
After doing additional testing I figured that that wasn't the issue.
The issue of broekn shells seems to be related to duplicate inclusion of distrobox hooks
when profile.d available.
While provided patch works a more comprehensive solution might be required to cover all cases.
In general we should inject hooks only once (first start or creation).
Since injecting on every start prevents customization of the container by the user
and can make it very difficult to identify shell/profile related issues (ask me how I know ;-))