Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name change permissions more flexible #30077

Open
alya opened this issue May 13, 2024 · 4 comments
Open

Make name change permissions more flexible #30077

alya opened this issue May 13, 2024 · 4 comments
Assignees
@Aditya8840
Labels
area: settings (admin/org) help wanted in progress priority: high

Comments

@alya
Copy link
Contributor

alya commented May 13, 2024 •
edited by timabbott

Organizations may want to restrict which users groups are allowed to change their Zulip name, rather than allowing/disallowing name changes across the board. For example, it may be useful to prevent guest users from changing their names.

We should therefore replace the "Prevent users from changing their name" setting with a more flexible choice, in the same location in SETTINGS / ORGANIZATION PERMISSIONS:

  • Label: Who can change their name

  • Options:
    Screenshot 2024-05-13 at 12 06 22@2x

  • Default to everyone being allowed to change their name.

  • For existing orgs, migrate the value of the "Prevent users from changing their name" option:

    • checked -> Admins
    • not checked -> everyone

This option should be implemented using the new groups system, like "Who can unsubscribe others from this channel?".

https://zulip.com/help/restrict-name-and-email-changes should be updated accordingly.

Related issues:
@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@alya alya mentioned this issue May 13, 2024
Open
@Aditya8840
Copy link
Collaborator

@zulipbot claim

@Aditya8840
Copy link
Collaborator

Hi @alya,
I have thoroughly reviewed the codebase, and based on my understanding, I can write a migration to change the 'Prevent users from changing their name' boolean field to a 'who can change' short integer. We will offer 5 choices for this field, such as admins, admins and moderators, etc., and will store the selected choice accordingly. Then, we will create a specific function to determine whether the current user can modify their name based on these choices. Finally, we will implement the necessary changes in the frontend. This is my approach to solve this issue. Can I proceed with this approach?

@alya
Copy link
Contributor Author

alya commented May 15, 2024

@Aditya8840 If you feel that you need feedback on your approach, please post a specific question in the Zulip development community. Be sure to follow https://zulip.readthedocs.io/en/latest/contributing/asking-great-questions.html. Thanks!

Aditya8840 added a commit to Aditya8840/zulip that referenced this issue May 17, 2024
@Aditya8840
settings: Replace 'Prevent users from changing their name' with group…
fd9f786 
…-based policy.

Replaces the 'Prevent users from changing their name' setting with a flexible 'Who can change their name' option in SETTINGS / ORGANIZATION PERMISSIONS.
Uses the new groups system for implementation.
Updated documentation accordingly.
This commit fixes zulip#30077.
@Aditya8840 Aditya8840 mentioned this issue May 17, 2024
Closed
12 tasks
Aditya8840 added a commit to Aditya8840/zulip that referenced this issue May 17, 2024
@Aditya8840
settings: Replace 'Prevent users from changing their name' with group…
df07618 
…-based policy.

Replaces the 'Prevent users from changing their name' setting with a flexible 'Who can change their name' option in SETTINGS / ORGANIZATION PERMISSIONS.
Uses the new groups system for implementation.
Updated documentation accordingly.
This commit fixes zulip#30077.
Aditya8840 added a commit to Aditya8840/zulip that referenced this issue May 18, 2024
@Aditya8840
settings: Replace 'Prevent users from changing their name' with group…
cab3da1 
…-based policy.

Replaces the 'Prevent users from changing their name' setting with a flexible 'Who can change their name' option in SETTINGS / ORGANIZATION PERMISSIONS.
Uses the new groups system for implementation.
Updated documentation accordingly.
This commit fixes zulip#30077.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aditya8840 Aditya8840

Labels
area: settings (admin/org) help wanted in progress priority: high
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

settings: Replace 'Prevent users from changing their name' with group-based policy. Aditya8840/zulip
3 participants
@alya @zulipbot @Aditya8840