Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: lpuart: uart_async_api: build failure for mimxrt10xx series #72308

Closed
hakehuang opened this issue May 4, 2024 · 3 comments · Fixed by #72955
Closed

tests: lpuart: uart_async_api: build failure for mimxrt10xx series #72308

hakehuang opened this issue May 4, 2024 · 3 comments · Fixed by #72955
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug

Comments

@hakehuang
Copy link
Collaborator

Describe the bug
Build failure

Please also mention any information which could help others to understand
the problem you're facing:

  • What target platform are you using?
  • mimxrt10xx, mr_canhubk3, mimxrt11xx series
  • What have you tried to diagnose or workaround this issue?
  • NA
  • Is this a regression? If yes, have you been able to "git bisect" it to a
    specific commit?
9320907fdf1f6dc436c426d4d31f0a0f6d2d2e8f is the first bad commit
commit 9320907fdf1f6dc436c426d4d31f0a0f6d2d2e8f
Author: Declan Snyder <declan.snyder@nxp.com>
Date:   Wed Apr 24 19:37:48 2024 -0500

    drivers: uart_mcux_lpuart: Fix APIs used together
    
    Handle controller instances wanting to use different
    API instances, need to change init flow so that they dont
    interfere with each other, trick for now is returning
    either the interrupt driven or async apis as not enabled
    if the other has already been used on that controller.
    
    Previously, there was an issue where enabling CONFIG_UART_ASYNC_API
    would overwrite the init even if controller was meant to use
    interrupt driven (as kconfig is global to affect all the controllers)
    
    Signed-off-by: Declan Snyder <declan.snyder@nxp.com>

 drivers/serial/uart_mcux_lpuart.c | 193 ++++++++++++++++++++++++++++----------
 1 file changed, 143 insertions(+), 50 deletions(-)

To Reproduce
Steps to reproduce the behavior:

scripts/twister -p mimxrt10160_evk -T mimxrt1170_evk@B/mimxrt1176/cm7 --build-only

Expected behavior
Build pass

Impact
build CI

Logs and console output

/home/jenkins/agent/workspace/bitbucket_build_platform/zephyr/drivers/serial/uart_mcux_lpuart.c:1030:12: error: 'mcux_lpuart_configure_async' defined but not used [-Werror=unused-function]
 1030 | static int mcux_lpuart_configure_async(const struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.

Environment (please complete the following information):

  • OS: (e.g. Linux, MacOS, Windows)
  • Toolchain (e.g Zephyr SDK, ...)
  • Commit SHA or Version used: v3.6.0-3395-g1ae357850d5c
@hakehuang hakehuang added bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP labels May 4, 2024
@nashif nashif added the priority: low Low impact/importance bug label May 7, 2024
@dleach02 dleach02 assigned decsny and unassigned decsny May 14, 2024
@decsny
Copy link
Member

decsny commented May 15, 2024

@hakehuang i don't understand the reproduce step you gave, what sample did you run, and was it rt1060 or rt1170?

@hakehuang
Copy link
Collaborator Author

hakehuang commented May 16, 2024

@hakehuang i don't understand the reproduce step you gave, what sample did you run, and was it rt1060 or rt1170?

@decsny it is not a run problem, it is a build issue, zephyr CI does not allow build warning, and in this driver there is an unused fucntion which will cause CI to warn, and the CI build flag is set to wran to error

'mcux_lpuart_configure_async' is called only when 'CONFIG_UART_EXCLUSIVE_API_CALLBACKS' defines, so it is better to refactor this dependency in this driver

@nordic-krch
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants