Tm/boolean ifthenelse #1155
Merged
Tm/boolean ifthenelse #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a prelude to integer. To access blocks from an integer ciphertext, some traits needs to be in scope. The common way to make it easy for end users it via a prelude. ```rust use tfhe::integer::prelude::*; ```
tmontaigu
force-pushed
the
tm/boolean-ifthenelse
branch
2 times, most recently
from
ca55f6a
to
e304d88
Compare
IceTDrinker
reviewed
May 17, 2024
Comment on lines
72
to
143
| pub fn if_then_else_parallelized<T>( | ||
| fn if_then_else_parallelized( | ||
| &self, | ||
| condition: &BooleanBlock, | ||
| true_ct: &BooleanBlock, | ||
| false_ct: &BooleanBlock, |
There was a problem hiding this comment.
There is a docstring
There was a problem hiding this comment.
But the docstrings are inverted 🤦
IceTDrinker
reviewed
May 17, 2024
tmontaigu
force-pushed
the
tm/boolean-ifthenelse
branch
2 times, most recently
from
66f5c98
to
cdfc783
Compare
|
make pcc 😭 |
This adds if_then_else/cmux on BoleanBlock for integer API and FheBool for HLAPI. To have the same name for both default version of the API in integer a trait was introduced. Ideally we would have wanted to do the boolean cmux in one PBS by packing data like this `(cond * 4) + (if * 2) + else` but this would not respect the max norm2. BREAKING CHANGE: integer::ServerKey::if_then_else_parallelized requires the trait ServerKeyDefaultCMux to be in scope.
tmontaigu
force-pushed
the
tm/boolean-ifthenelse
branch
from
cdfc783
to
b7b0651
Compare
IceTDrinker
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds if_then_else/cmux on BoleanBlock for integer API
and FheBool for HLAPI.
To have the same name for both default version of the API
in integer a trait was introduced.
Ideally we would have wanted to do the boolean cmux in one PBS by
packing data like this
(cond * 4) + (if * 2) + elsebut thiswould not respect the max norm2.
BREAKING CHANGE: integer::ServerKey::if_then_else_parallelized requires the
trait ServerKeyDefaultCMux to be in scope.
Fixes #825
This PR also has the commit that creates the prelude