Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM Renderer: display underline when selection link content #4811

Open
tisilent opened this issue Sep 18, 2023 · 3 comments · May be fixed by #5055
Open

DOM Renderer: display underline when selection link content #4811

tisilent opened this issue Sep 18, 2023 · 3 comments · May be fixed by #5055
Labels

Comments

@tisilent
Copy link
Contributor

20230918_222155.mp4
@jerch
Copy link
Member

jerch commented Sep 18, 2023

Regarding link handling the DOM renderer is pretty straight forward - it re-renders a line with underlines applied/remove from the linkifier events. A quickfix is prolly possible by internally eval'ing the selection state.

A better long-term fix would involve changes on the linkifier, as the question here is, why it sends link events for selections in the first place. The mouse listeneners are quite scattered over the codebase currently, imho we would need a proper mouse listener service as a global orchestrator to fix this more reliably in the future.

@tisilent
Copy link
Contributor Author

Fixed it, there is still an issue where the dashed line will not be visible. 🤪

@tisilent tisilent linked a pull request May 13, 2024 that will close this issue
@tisilent
Copy link
Contributor Author

企业微信截图_17155832327359
Two types of underline can be displayed simultaneously.
But this method doesn't feel very good.
Need to process the curve...... 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants