Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of sink is different to Swift TCA #5

Open
allforabit opened this issue May 28, 2021 · 1 comment
Open

Behaviour of sink is different to Swift TCA #5

allforabit opened this issue May 28, 2021 · 1 comment

Comments

@allforabit
Copy link

allforabit commented May 28, 2021

Hi there, I was delighted to see that some work has started on porting the composable architecture to Kotlin. It looks great. Have just started playing around with it by copying and pasting some of the code to try the basic idea. I noticed that effects processing behaves a little different to Swift TCA. This processes one value at a time as it's received from the flow. However in the version here it uses .toList which means the flow will have to complete before any actions are sent back into the store.

@humblehacker
Copy link

In case anyone's interested, I've attempted a fix for this in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants