Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Set image-rendering: crisp-edges; #17

Open
cjke opened this issue Sep 3, 2020 · 3 comments
Open

Firefox: Set image-rendering: crisp-edges; #17

cjke opened this issue Sep 3, 2020 · 3 comments

Comments

@cjke
Copy link

cjke commented Sep 3, 2020

Cool project, just starting to have a poke around. On Firefox the first impressions are a little skewed because the images are quite blurry.

If you simply apply image-rendering: crisp-edges; will fix the issue.

Before on Firefox
image

After on Firefox
image

I'm happy to do a PR, I'd imagine it would be here right?
https://github.com/vsmode/pixel8/blob/master/src/components/Stage.js#L235

@jozanza
Copy link
Member

jozanza commented Sep 6, 2020

@cjke a PR would be great. That looks like the right spot to me!

@cjke
Copy link
Author

cjke commented Sep 14, 2020

Apologies about the delay - I've started to look at this tonight, but I hit a snag with styleguidedist (which I haven't used before).

Have you seen this error:

image

This is after a fresh install:

  • git clone git@github.com:vsmode/pixel8.git
  • npm install
  • npm run styleguide

@jozanza
Copy link
Member

jozanza commented Sep 19, 2020

I'm going to take a look right now and get to the bottom of this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants