Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revalidate ignored for index route of a catch all route #65842

Closed
nsams opened this issue May 16, 2024 · 1 comment · Fixed by #65843
Closed

Revalidate ignored for index route of a catch all route #65842

nsams opened this issue May 16, 2024 · 1 comment · Fixed by #65843
Labels
bug Issue was opened via the bug report template. locked Runtime Related to Node.js or Edge Runtime with Next.js.

Comments

@nsams
Copy link
Contributor

nsams commented May 16, 2024 •
edited

Link to the code that reproduces this issue

https://codesandbox.io/p/devbox/eager-field-nfwnh6?file=%2Fapp%2F%5B%5B...path%5D%5D%2Fpage.tsx%3A11%2C1&workspaceId=158e05b4-11a3-4a66-8a49-f399b2b301f5

To Reproduce

  1. start the application using next build && next start (done by codesandbox task)
  2. open / and refresh a few times
  3. notice the page re-renders every second
  4. open /foo and refresh a few times
  5. notice the page re-renders every 10 seconds (as specified by revalidate)

Current vs. Expected behavior

Full Route Cache should also respect revalidate for / route

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP PREEMPT_DYNAMIC Sun Aug  6 20:05:33 UTC 2023
  Available memory (MB): 4102
  Available CPU cores: 2
Binaries:
  Node: 20.9.0
  npm: 9.8.1
  Yarn: 1.22.19
  pnpm: 8.10.2
Relevant Packages:
  next: 14.3.0-canary.63 // Latest available version is detected (14.3.0-canary.63).
  eslint-config-next: N/A
  react: 19.0.0-beta-4508873393-20240430
  react-dom: 19.0.0-beta-4508873393-20240430
  typescript: 5.1.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Runtime

Which stage(s) are affected? (Select all that apply)

next start (local)

Additional context

No response
@nsams nsams added the bug Issue was opened via the bug report template. label May 16, 2024
@github-actions github-actions bot added the Runtime Related to Node.js or Edge Runtime with Next.js. label May 16, 2024
@nsams nsams mentioned this issue May 16, 2024
Merged
nsams added a commit to nsams/next.js that referenced this issue May 18, 2024
@nsams
Add test that reproduces vercel#65842
10176d2
ijjk added a commit that referenced this issue May 20, 2024
@nsams @ijjk
Fix revalidateTimings route for catchall index route (#65843)
8a429e0 
fixes #65842

When setting revalidateTimings correctly use toRoute to convert `/index`
to `/`, like done for get
(https://github.com/vercel/next.js/blob/canary/packages/next/src/server/lib/incremental-cache/index.ts#L213)

See #65842 for reproduction codesandbox.

The bug also exists in 14.2.3 (and below) - before #64370

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Jun 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template. locked Runtime Related to Node.js or Edge Runtime with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix revalidateTimings route for catchall index route nsams/next.js
1 participant
@nsams