secret type aws_secrets_manager not working with a sequence of numbers as string value

[sdomme]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Hi. I'm using the new secret type aws_secrets_manager. It seems not to cast string secret values correctly. Especially if the value is a sequence of numbers set as string.

For example having the following AWS secret as JSON:

{
  "username":"12345",
  "password":"abc"
}

With the following configuration

secret:
  loki:
    secret_id: "arn:aws:secretsmanager:....."
    type: "aws_secrets_manager"
sink:
  loki:
    auth:
      password: "SECRET[loki.password]"
      user: "SECRET[loki.username]"
      strategy: "basic"
    type: "loki"

I get the following error at vector startup:

2024-05-13T15:32:54.549469Z ERROR vector::cli: Configuration error. error=invalid type: integer `12345`, expected a string

Configuration

No response

Version

0.38.0

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

[junaidk]

I had similar issue when using Helm to deploy.
Double quotes are removed from created configmap for vector config.
This results in config values without quotes like this .

      auth:
        strategy: basic
        password: SECRET[loki.password]
        user: SECRET[loki.username]

If value is numeric and without quote it will be parsed as number.

You can define your username like this to render double quotes so that it is parsed as string by vector.

      auth:
        strategy: basic
        password: "SECRET[loki.password]"
        user: '{{ print "SECRET[loki.username]" }}'

[jszwedko]

I believe @junaidk is correct so I'll close this out, but let me know if you have any additional questions!

[sdomme]

@junaidk Thanks for this very valuable hint. I hadn't thought about this. Works now. 👍🏻