Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is "add_question_sql" storing vectors as question+sql? SQL isn't natural language, so it wouldn't affect the semantic matching of input queries? #447

Closed
qingwu11 opened this issue May 17, 2024 · 2 comments

Comments

@qingwu11
Copy link

ques+sql
Why is "add_question_sql" storing vectors as question+sql? SQL isn't natural language, so it wouldn't affect the semantic matching of input queries?

@qingwu11 qingwu11 added the bug Something isn't working label May 17, 2024
@erickrribeiro
Copy link

erickrribeiro commented May 17, 2024

Yes, @qingwu11. I also wondered the same thing when I saw how this id is created. I think that only the question field should be used to generate the unique code and not the question+sql

@zainhoda
Copy link
Contributor

In our testing we actually did find better search by embedding the SQL query particularly if it contains specific terminology that may not be contained in the question.

However, to @erickrribeiro 's point -- I think that the ID should only be based on the question

@zainhoda zainhoda removed the bug Something isn't working label May 20, 2024
@vanna-ai vanna-ai locked and limited conversation to collaborators May 23, 2024
@zainhoda zainhoda converted this issue into discussion #452 May 23, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants