Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing message for command 'upgrade' #527

Open
tbrowder opened this issue Sep 15, 2023 · 4 comments
Open

Confusing message for command 'upgrade' #527

tbrowder opened this issue Sep 15, 2023 · 4 comments

Comments

@tbrowder
Copy link

When running

zef upgrade Foo

whose current version is 1, the current response is approximately

...will upgrade version 2...

A friendlier message would be something like:

...upgrade from version 1 to version 2...
@ugexe
Copy link
Owner

ugexe commented Sep 15, 2023

The current message makes more sense in the context of potentially multiple versions having already been installed

@tbrowder
Copy link
Author

Then just

...installing ...

@ugexe
Copy link
Owner

ugexe commented Sep 22, 2023

I believe it will already say ...installing... later on when the install actually happens, so I don't want to duplicate that. I wonder if the upgrade text should instead reference the original module without version. For instance, zef upgrade zef should say like updating zef:auth<github:ugexe> (and later on the installing zef:auth<github:ugexe>:ver<...>)

@tbrowder
Copy link
Author

Sounds like an improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants