This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Vim Vixen doesn't work properly with single page web apps. #739
Labels
site compatible
issue occurs on certain site
Comments
diff --git a/src/content/usecases/FollowSlaveUseCase.ts b/src/content/usecases/FollowSlaveUseCase.ts
index 56c8883..f7a145d 100644
--- a/src/content/usecases/FollowSlaveUseCase.ts
+++ b/src/content/usecases/FollowSlaveUseCase.ts
@@ -68,7 +68,7 @@ export default class FollowSlaveUseCase {
openNewTab = true;
}
// eslint-disable-next-line no-script-url
- if (!url || url === "#" || url.toLowerCase().startsWith("javascript:")) {
+ if (!newTab || !url || url === "#" || url.toLowerCase().startsWith("javascript:")) {
hint.click();
return;
}This seems to work properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm opening this issue because:
Description
I have a single page web app, where most of the links use the browser history router to navigate to different pages. Vim Vixen, instead of following those onClick / onFollowLink directives (or just simulating a click), reloads the web page when using
f. My site: https://dev.lemmy.mlSteps to Reproduce
fto follow link.freloads the page.System configuration
The text was updated successfully, but these errors were encountered: