Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portlets without chrome don't have the appropriate feedback for users using screen readers #1953

Open
jonathanmtran opened this issue Feb 6, 2020 · 0 comments
Labels

Comments

@jonathanmtran
Copy link
Contributor

jonathanmtran commented Feb 6, 2020

Describe the bug
When using NVDA with Chrome, when on a page that has a single no-chrome portlet (and possibly many no-chrome portlets), pressing tab after "Your feedback is important to us" puts the focus on following portlet's .up-portlet-wrapper but nothing is announced via NVDA unless the user presses the down arrow (several) times to have the content announced to them.

Since nothing is announced and the focus is on .up-portlet-wrapper, the user may try pressing enter to get some kind of response. Since the previous link they tabbed from is the "Your feedback is important to us", then the user will be navigated away to the feedback portlet

I noticed that if I commented out the following code, things behave as expected, but portlet reordering would break.

https://github.com/Jasig/uPortal/blob/master/uPortal-webapp/src/main/webapp/media/skins/common/javascript/uportal/up-layout-preferences.js#L632-L705

It seems like it's an issue when we're dealing with no-chrome portlets, but I'm not sure exactly where the problem lies.

To Reproduce
Steps to reproduce the behavior:

  1. Spin up a vanilla instance of uPortal from uPortal-start
  2. Start NVDA
  3. Log in as an admin
  4. Tab all the way to the "Your feedback is important to us" link
  5. Press tab. The focus is now on the .up-portlet-wrapper section of the admin. dashboard but nothing is announced
  6. a) If the enter key is pressed, you will be navigated to the feedback portlet
    b) If the down arrow key is pressed, the screen reader will read the elements with successive presses of the down arrow key

Expected behavior

  • When the keyboard/visual focus shifts to the portlet, it should be recognized and announced by assistive technologies.
  • Pressing the enter key while the focus is on .up-portlet-wrapper should not navigate the user to the previous link they were on

Platform:

  • uPortal Version: uPortal 5.8.1
  • OS: Windows 10
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant