Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): remove deprecated no-throw-literal rule #9083

Closed
JoshuaKGoldberg opened this issue May 13, 2024 · 1 comment
Closed
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Following #6109 -> #8701: we deprecated the no-throw-literal rule but, to avoid a breaking change, left the deprecated rule in existence. Our v8 branch can have these breaking changes. Let's delete the no-throw-literal rule! 🙌

Note that this PR should be against the v8 branch, not main.

💖

@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin breaking change This change will require a new major version to be released accepting prs Go ahead, send a pull request that resolves this issue labels May 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone May 13, 2024
@JoshuaKGoldberg
Copy link
Member Author

#9092 was merged into the v8 branch. ✅

n0099 added a commit to n0099/open-tbm that referenced this issue Jun 5, 2024
…@typescript-eslint/parser.

The file was not found in any of the provided program instance(s):` by vuejs/vue-eslint-parser#104 (comment)
* reset `languageOptions.parserOptions.ecmaVersion` to `latest` as it's set to `2018` by `pluginImportX.configs.recommended`
- rules from `@typescript-eslint` for file `eslint.config.js`
* simplify the importing of `vite.config.ts`
* ignore files generated by yarn
- rule `@typescript-eslint/no-throw-literal`: typescript-eslint/typescript-eslint#9083
@ eslint.config.js

$ yarn eslint --fix
@ fe
n0099 added a commit to n0099/open-tbm that referenced this issue Jun 5, 2024
…@typescript-eslint/parser.

The file was not found in any of the provided program instance(s):` by vuejs/vue-eslint-parser#104 (comment)
* reset `languageOptions.parserOptions.ecmaVersion` to `latest` as it's set to `2018` by `pluginImportX.configs.recommended`
- rules from `@typescript-eslint` for file `eslint.config.js`
* simplify the importing of `vite.config.ts`
* ignore files generated by yarn
- rule `@typescript-eslint/no-throw-literal`: typescript-eslint/typescript-eslint#9083
@ eslint.config.js

$ yarn eslint --fix
@ fe
n0099 added a commit to n0099/open-tbm that referenced this issue Jun 5, 2024
…@typescript-eslint/parser.

The file was not found in any of the provided program instance(s):` by vuejs/vue-eslint-parser#104 (comment)
* reset `languageOptions.parserOptions.ecmaVersion` to `latest` as it's set to `2018` by `pluginImportX.configs.recommended`
- rules from `@typescript-eslint` for file `eslint.config.js`
* simplify the importing of `vite.config.ts`
* ignore files generated by yarn
- rule `@typescript-eslint/no-throw-literal`: typescript-eslint/typescript-eslint#9083
@ eslint.config.js

$ yarn eslint --fix
@ fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

1 participant