fix(scope-manager): handle index signature in class #9054
Conversation
|
Thanks for the PR, @yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoshuaKGoldberg
added
the
1 approval
| type Foo = string; | ||
| export class Bar { | ||
| [x: Foo]: any; | ||
| } | ||
| `, |
There was a problem hiding this comment.
Could you add a test for [x: string]: Foo?
| @@ -259,6 +259,11 @@ const obj = { | |||
| }, | |||
| }; | |||
| `, | |||
| ` | |||
| class Foo { | |||
| [x: string]: any; | |||
There was a problem hiding this comment.
Could you add invalid versions? Both [x: Foo]: string and [x: string]: Foo
| @@ -0,0 +1,3 @@ | |||
| class Foo { | |||
| [x: string]: any; | |||
There was a problem hiding this comment.
I think we should also use [x: Foo]: string and [x: string]: Foo here, otherwise the snapshot doesn't contain anything about the index signature
PR Checklist
Overview