New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log email attachments #4108
Comments
@quest-bot embark |
Check the docs for more info. |
@FelixMalfait do you all use any centralized access for shared secrets? Specifically here I needed AUTH_GOOGLE_CLIENT_ID and AUTH_GOOGLE_CLIENT_SECRET. I went through the process of spinning up a personal google integration, but I'm curious about this for future PRs. |
@tatethurston sorry for the delayed reply! We don't really have better process no, every just setup their own. I don't know if it would be possible to do otherwise 🤔 |
No worries. I have limited capacity and don’t think I’ll be able to push this one through for a few weeks. Happy to let someone else take this on. |
I would like to work on this issue. |
Hey guys, i just started looking into this one. Please @FelixMalfait assign this issue to me. I was able to set up my own Google credentials and sync a few emails. Is there any preferred way to work with the email sync other than calling a manual command e.g. |
@varunKT001 thanks! Since this issue is a very complex one, you might want to start with smaller issues first. @rostaklein has some experience on the code base so I'm assigning it to him, but feel free to take another one! cc @bosiraphael any tip to give to @rostaklein? thanks |
@FelixMalfait sure no issues. I'll pick another issue 👍 |
Hello @rostaklein, thank you for taking this issue :) Here are some insights: Currently, we're querying the raw email from gmail API using mailparser to parse the email content and headers. Make a second query for files with attachments (Simpler)
This solution is simpler but we're wasting bandwidth because we're getting the whole attachment and doing nothing with it, and we also have to do a second query. Change the query format to full instead of raw and modify the parsing logic (Better)
|
Context
We've built an integration with gmail which allows workspace members to connect their accounts and import all emails. Those emails are then automatically attached to company/contacts.
The gmail API exposes attachments for every message but we ignore them.
The goal of this issue would be to import attachments in our database to then display them in the Files tab and in email threads.
Backend
The steps on the backend side should roughly look like this:
This is just a general guideline, this a complex issue that will require investigation!
Frontend
Because we use the existing Attachment object it should automatically appear in Files tabs (nothing to do?)
We should also add a clipper icon on the threads list
Link to Figma
The text was updated successfully, but these errors were encountered: