Command requesting a new popup window with a container creates a regular window

[asteroidcow]

• Brief description of the problem:

When using a command to run winopen() with -popup and -c Foo, the -popup flag is ignored.

• Steps to reproduce:

Invoke the following command

command work jsb ['office.com','slack.com'].reduce((prev, url) => prev.then(() => tri.excmds.winopen('-popup', '-c', 'Work', 'https://' + url)), Promise.resolve());

• Tridactyl version = 1.24.0
• Firefox version = 124.0.1

[bovine3dom]

Good spot, thanks.

Firefox doesn't support opening new windows with containers so our current workaround is to make a tab in a container and then detach it.

tridactyl/src/excmds.ts

Line 3278 in f49e1c9

return tabopen(...args).then(() => tabdetach())

In theory, pop-up windows don't support tabs but we can hack it in by merging tabs into them. So

1. make a popup window
2. make a tab with the container in the current window
3. merge that tab into the popup window
4. close the original popup window tab