Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TypeScript 4 #4622

Open
bovine3dom opened this issue Mar 10, 2023 · 3 comments · May be fixed by #4624
Open

Update to TypeScript 4 #4622

bovine3dom opened this issue Mar 10, 2023 · 3 comments · May be fixed by #4624
Labels
P3

Comments

@bovine3dom
Copy link
Member

The main thing blocking this issue is that TypeDoc 0.20+ broke something (#4459).

We would also need to remove the last vestiges of tslint.

Presumably there are other things that would need updating too.

(Raised by @treapster in #4617)
@bovine3dom bovine3dom added the P3 label Mar 10, 2023
@bovine3dom bovine3dom mentioned this issue Mar 10, 2023
Open
@treapster
Copy link
Contributor

Judging by the logs, removing--ignoreCompilerErrors should fix the breakage.

@bovine3dom
Copy link
Member Author

We even waited long enough to upgrade that an equivalent option got added back in :) TypeStrong/typedoc#1975

We need to update TypeScript to get that though.

@bovine3dom bovine3dom linked a pull request Mar 10, 2023 that will close this issue
Draft
@bovine3dom
Copy link
Member Author

https://github.com/TypeStrong/typedoc/blob/master/internal-docs/custom-themes.md I've had this tab open for months, presumably it's relevant somehow to what we need to do

See also 92c1563

I'll try to look at this again soon.

I remember it being so frustrating the last time I looked at it that I was put off working on Tridactyl for a while ... this time it will go better 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade typescript to version 4 tridactyl/tridactyl
2 participants
@bovine3dom @treapster