-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More resiliant approach for in-flight requests on terminating Pods #10730
Comments
Hello @alen-z and thanks for your interest in Traefik, This is an interesting idea, there is already a pull request #10664 which brings the EndpointSlices support which might fix this issue. @jnoordsij wdyt? |
I've looked into the mentioned KEP, but I just don't see how exactly it should benefit Traefik. In both the existing handling of endpoints and the one I implemented with the The What could be done after #10664 is creating some kind of configuration flag (or even/later default behavior), that does broadly the same thing as the mentioned KEP: rather than relying on the However, I'm not sure if this has any real-world benefit, as the motivation mentions the problem at hand being "When using Service Type=LoadBalancer w/ externalTrafficPolicy=Local" while Traefik should typically be sending traffic to |
Hey @jnoordsij, great gist and appreciate the time invested. Also, pretty nice to see #10664. I wasn't aware, pretty new from the Traefik kitchen. Ultimate goal: Removing the need to have I have one thing in mind: Can Traefik intervene in the process of How to involve Traefik in a similar way that |
I see! I do like the idea, although I think it might be very challenging to achieve such a thing in practice. But as far as I can see, that goal does not have any direct relation to KEP-1669 or my PR #10664, given they're really about something else (namely the endpoint part) and do not actively attempt to alter Pod termination logic itself in any way. |
Yes, you are right. KEP was just initial spark that evolved. Glad you find it interesting. If there is a way to try this, maybe we can put it behind a flag to start with. |
Welcome!
What did you expect to see?
Is Traefik about to rely on state of EndpointSlice to determine when to continue sending traffic to terminating Pods?
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1669-proxy-terminating-endpoints/README.md
ProxyTerminatingEndpoints
Kuberentes flags are already live in GKE for example.This would make Traefik much more reliable in cases where
preStop
hook is not implemented.The text was updated successfully, but these errors were encountered: