🚀 Feature: Make Instrumentations Robust to How Users Call Functions (args/kwargs) #539
Open
1 task done
Labels
enhancement
New feature or request
Which component is this feature for?
All Packages
🔖 Feature description
I've noticed some instrumentations only check for the
kwargs
passed by the method. For instance, in ChromaDB:This has the implication that depending on the user calls the function, he might miss some attributes from being added to the trace.
For instance:
Would not instrument the arguments, while calling:
Would successfully include attributes
id
andcollection
in the trace.🎤 Why is this feature needed ?
Make instrumentations more robust / reliable / predictable. We don't want the behavior to change depending on the user calls a method.
✌️ How do you aim to achieve this?
We should make this is baked-in in the instrumentation tooling, so that this always handled correctly. We need some code design proposal done and experimented with. This is what I've implemented in weaviate instrumentation to avoid the issue and could serve as a starting point:
🔄️ Additional Information
Note, this could also be labeled as a bug, but I think the goal here is not to simple fix cases where it might misbehave. It's to prevent it from even happening again in the future.
👀 Have you spent some time to check if this feature request has been raised before?
Are you willing to submit PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: