-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: Build issue with Module Not Found Error #1067
Comments
If I add this module, it then leads to the next missing dep, see below.
|
Hey @damianoneill this is weird, these should be installed with OpenTelemetry. Can you verify that |
Thanks @nirga for the quick response. See below, where I wiped the virtual environment and reinstalled from scratch.
|
And the pip list
|
@damianoneill Everything looks right, and we have users that use OpenLLMetry with langserve. Can you compare your code to this example with langserve? #1043 Also, welcome to join our community slack might be easier to communicate - https://traceloop.com/slack |
@nirga thanks for your patience, I'm not a python developer 😄 and for the pointer to the PR. You are referencing the source, rather than including it in the dep section (and pulling from pypi) as I have done.
So I checked out your PR, updated the dep to pull it in and started the langchain serve command, no complaints about missing modules, it bombs out with a missing TRACELOOP_API_KEY, as expected. So I then used poetry show --tree to see where the deps are being installed from, it looks like there coming from your use of chromadb. For example:
Note the import of importlib-resources and further imports of all the opentelemetry packages come later, e.g. opentelemetry-exporter-otlp-proto-grpc >=1.2.0 Please correct me if I'm wrong, but it seems that the libraries need to be manually imported. That including traceloop-sdk wont be enough? Damian. |
Hmm I'll try to reproduce it locally. It should work without requiring any extra dependencies and I'm not aware of anyone else needing this 🤔 |
@nirga dont worry, I'll progress myself, you've given me enough to start working through and excluding stuff until I find the issue. Appreciate your help with this. |
@nirga apologies, I've found the issue, it has nothing to do with your environment. I'm behind a corporate firewall, if I build on my home computer, there are no issues, so looks like somehow the opentelemetry modules are not getting pulled on our VPN. Thankyou for your help, sorry for being a distraction. |
Closing issue. |
@damianoneill thanks for verifying! 🙏🏼 |
Which component is this bug for?
Traceloop SDK
📜 Description
Sorry this is more of a question than a Bug Report, didn't see any options for asking a question.
I have an existing, running Langchain (Langserve) application. I have added the following in the python mainline
And my pyproject.toml file includes the following dependencies
I am using the following python version
When I run this, I get the following error.
Apologies if this is a newbie question, I was expecting that all the required dependencies would be pulled, can you confirm if I am supposed to import all the missing modules? Or is there something that I have done wrong.
I have looked at a few other pyproject.toml files and do not see them bringing in a list of 3rd parties.
Thanks in advance,
Damian.
👟 Reproduction steps
N/A - build question
👍 Expected behavior
It should startup with error.
👎 Actual Behavior with Screenshots
🤖 Python Version
3.11.6 on OSX
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
Are you willing to submit PR?
None
The text was updated successfully, but these errors were encountered: