Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stealth: Missing Reviews #31

Open
5 of 10 tasks
cookiengineer opened this issue Apr 9, 2020 · 3 comments
Open
5 of 10 tasks

Stealth: Missing Reviews #31

cookiengineer opened this issue Apr 9, 2020 · 3 comments
Assignees
Labels
feature Feature discussions and requests. in-progress Task is in progress

Comments

@cookiengineer
Copy link
Member

cookiengineer commented Apr 9, 2020

The request/*.mjs Modules need reviews.

  • Implement Blocker.check
  • Implement Downloader.check
  • Implement Downloader.download
  • Implement Optimizer.check
  • Implement Optimizer.optimize

Additionally, the following Core Implementations need reviews, too:

  • stealth/Browser
  • stealth/Request
  • stealth/Session
  • stealth/Settings
  • stealth/Tab
@cookiengineer cookiengineer changed the title Stealth: request Helpers need reviews Stealth: Missing Reviews Apr 28, 2020
@cookiengineer cookiengineer self-assigned this Apr 28, 2020
@cookiengineer cookiengineer added this to the X0 - Codename Spirit milestone Apr 28, 2020
@cookiengineer
Copy link
Member Author

cookiengineer commented May 23, 2020

As of 9091744 most of the core functionality is now tested end-to-end, including the Request API.

As Covert meanwhile uses the check action to verify the contents of a Review against its Implementation, the test coverage got pretty high.

Some Network Protocols have still to be tested, in particular:

stealth/protocol/HTTP:

  • HTTP.upgrade()

stealth/protocol/HTTPS:

  • HTTPS.upgrade()

stealth/protocol/WS:

  • WS.receive()
  • WS.upgrade()

stealth/protocol/WSS:

  • WSS.upgrade()
  • WSS.receive()

Currently, I have no idea how to implement those tests, as all of them are quite complicated in their handled network states and asynchronous interactions with them on the counter-part.

@cookiengineer cookiengineer added feature Feature discussions and requests. in-progress Task is in progress labels Sep 20, 2020
@cookiengineer
Copy link
Member Author

The Session service needs further Reviews once the integration with the UI cards has been implemented.

So far, these were the newly added methods to stealth/server/Session and stealth/client/Session:

  • Session.remove()

@cookiengineer
Copy link
Member Author

The Blockers service has changed now, too, and needs a better Review.

  • Fix Settings Review
  • Fix Settings Service Reviews (client/server)
  • Fix Blocker Service Review (client/server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature discussions and requests. in-progress Task is in progress
Projects
None yet
Development

No branches or pull requests

1 participant