Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests have invalid cookie header #180

Open
alethiophile opened this issue Jan 20, 2021 · 0 comments
Open

requests have invalid cookie header #180

alethiophile opened this issue Jan 20, 2021 · 0 comments

Comments

@alethiophile
Copy link

At https://github.com/theelous3/asks/blob/master/asks/request_object.py#L215, the Cookie header string is constructed from the cookies dictionary using the delimiter "; ". However, only the last character (rather than the last two characters) of the final string is trimmed off after the final iteration. This leaves an extraneous ; on the end of the Cookie header string; this is in violation of RFC 6265, and also breaks authentication on some servers I'm using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant