Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terser returns error if folders, specified in --output parameter are not present in file system #962

Open
alexejibishvili opened this issue Mar 18, 2021 · 5 comments · May be fixed by #1530
Open

Terser returns error if folders, specified in --output parameter are not present in file system #962

alexejibishvili opened this issue Mar 18, 2021 · 5 comments · May be fixed by #1530
Labels
enhancement

Comments

@alexejibishvili
Copy link

Hello!

Can't exactly say its a bug or I'm missing something

Version: terser 5.6.1

I run a command:
npx terser wwwroot/build/js/admin.js --compress typeofs=false --mangle --comments "/^!/" --output wwwroot/dist/js/admin.min.js

Then I get an error:
Error: ENOENT: no such file or directory, open 'wwwroot/dist/js/admin.min.js'
at Object.openSync (fs.js:476:3)
at Object.writeFileSync (fs.js:1467:35)
at run_cli (C:\Users\Alex\source\repos\x\src\Web\node_modules\terser\dist\bundle.min.js:26901:16)
at run_cli (C:\Users\Alex\source\repos\x\src\Web\node_modules\terser\dist\bundle.min.js:26782:5) {
errno: -4058,
syscall: 'open',
code: 'ENOENT',
path: 'wwwroot/dist/js/admin.min.js'
}

Expected result: I expect to see minified file in --output wwwroot/dist/js/admin.min.js

If I have "dist" folder empty with no subfolders, I get the error.
If I create "js" folder inside "dist" folder, then minified file is create and I get no error.

Am I missing something or terser just does not create output folders by itself?
@jridgewell
Copy link
Collaborator

Seems like we could use mkdirp to recursively create the output directory. This needs to be done at

terser/lib/cli.js

Line 304 in 38bef40

fs.writeFileSync(program.output, result.code);
.

@alistairtweedie
Copy link

Is there any appetite to work on this? 😕

@groovenectar
Copy link

I think it could be a nice option

@groovenectar
Copy link

Maybe not default behavior? I would definitely use it personally

@MohamedLamineAllal
Copy link

MohamedLamineAllal commented Nov 7, 2023 •
edited

Every file processing tool does support this. It doesn't make sense to not support it.
And it should be part of the CLI only.

RyanZim added a commit to RyanZim/terser that referenced this issue May 18, 2024
@RyanZim
Ensure parent directory exists when using --output on CLI
fe636a4 
Resolves terser#962
@RyanZim RyanZim linked a pull request May 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure parent directory exists when using --output on CLI RyanZim/terser
5 participants
@jridgewell @groovenectar @alistairtweedie @alexejibishvili @MohamedLamineAllal