-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttnn.sinh operation fails with low PCC in most situations #8598
Comments
I added mixed precision support to bcast on latest, so it should no longer crash. |
Hello, @tt-aho, I tried with rebasing to latest main today and its still failing. |
Hey, that was my mistake. I added support for it in the op itself but forgot to remove the assert. Should be resolved on latest main a1b9781 |
Hello @tt-aho, just rebased with latest main and rebuilt, but its still the same issue. Not sure what is happening. You can always test your self by running:
To see if its fixed. |
Hey, the crash/error should finally be resolved (d5c7fef). I've verified locally that it now only mismatches |
Confirmed. Now only PCC is failing. |
ttnn.sinh operation fails with low PCC in all tested situations.
Problem is observed on both GS and WH cards.
To Reproduce
Steps to reproduce the behavior:
ngrujic/op_bug_unit_tests
(soon to be merged intomain
).test_eltwise_sinh.py
using this command:pytest tests/ttnn/python_api_testing/non_working_unit_tests/grayskull/test_eltwise_sinh.py
Expected behavior
There are multiple test cases presented in the unit test, which are failing with low PCC.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweeps and check the results. To do this you should:
pytest tests/ttnn/python_api_testing/sweep_tests/run_sweep_test.py --input-path tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/grayskull/ttnn_eltwise_sinh_test.yaml --input-method cli --cli-input results_ttnn_sinh
The text was updated successfully, but these errors were encountered: