Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental build failure with CMake + Ninja #8580

Open
TT-billteng opened this issue May 17, 2024 · 1 comment
Open

Incremental build failure with CMake + Ninja #8580

TT-billteng opened this issue May 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working P2_should_have

Comments

@TT-billteng
Copy link
Collaborator

@pgkeller has seen incremental build when he touches a cq_commands.h

+++ b/tt_metal/impl/dispatch/cq_commands.hpp
@@ -138,8 +138,12 @@ struct CQDispatchWritePagedCmd {
     uint32_t pages;
 } __attribute__((packed));

+
+constexpr uint32_t CQ_DISPATCH_CMD_PACKED_WRITE_FLAG_NONE      = 0x00;
+constexpr uint32_t CQ_DISPATCH_CMD_PACKED_WRITE_FLAG_MCAST     = 0x01;
+constexpr uint32_t CQ_DISPATCH_CMD_PACKED_WRITE_FLAG_NO_STRIDE = 0x02;
 struct CQDispatchWritePackedCmd {
-    uint8_t is_multicast;
+    uint8_t flags;            // see above
     uint16_t count;           // number of sub-cmds (max 1020 unicast, 510 mcast). Max num sub-cmds = (dispatch_constants::TRANSFER_PAGE_SIZE - sizeof(CQDispatchCmd)) / sizeof(CQDispatchWritePacked*castSubCmd)
     uint32_t addr;            // common memory address across all packed SubCmds
     uint16_t size;            // size of each packet, stride is padded to L1 alignment and less than dispatch_cb_page_size
@TT-billteng TT-billteng added bug Something isn't working P2_should_have labels May 17, 2024
@TT-billteng TT-billteng self-assigned this May 17, 2024
@tt-aho
Copy link
Contributor

tt-aho commented May 17, 2024

I've had quite a few build failures as well with incremental build when I touch the lower level metal/runtime files, and I have to blow away the build folder to resolve. Didn't keep track of anything specific, but can track/update in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2_should_have
Projects
None yet
Development

No branches or pull requests

2 participants