Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-13-NSPAWN (machinectl) failed in GitHub Action #32888

Closed
yuwata opened this issue May 17, 2024 · 0 comments · Fixed by #32907
Closed

TEST-13-NSPAWN (machinectl) failed in GitHub Action #32888

yuwata opened this issue May 17, 2024 · 0 comments · Fixed by #32907
Labels
bug 🐛 Programming errors, that need preferential fixing machine tests

Comments

@yuwata
Copy link
Member

yuwata commented May 17, 2024

https://github.com/systemd/systemd/actions/runs/9115979814/job/25063532755?pr=32871

gh run download 9115979814 --name ci-mkosi-9115979814-1-debian-testing-failed-test-journals -D ci/ci-mkosi-9115979814-1-debian-testing-failed-test-journals

40/93 systemd:integration-tests / TEST-13-NSPAWN                                                FAIL            100.65s   exit status 1
>>> MALLOC_PERTURB_=190 SYSTEMD_INTEGRATION_TESTS=1 /home/runner/work/systemd/systemd/test/integration-test-wrapper.py --meson-source-dir /home/runner/work/systemd/systemd --meson-build-dir /mnt/mkosi/build --name TEST-13-NSPAWN --storage volatile --firmware linux --exit-code 123 --unit TEST-13-NSPAWN.service --
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
Listing only the last 100 lines from a long log.
[   64.878494] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   64.886885] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:17 UTC
[   64.897315] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   64.904411] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   64.908133] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   64.911457] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   64.913122] TEST-13-NSPAWN.sh[1113]: Name=container0
[   64.914622] TEST-13-NSPAWN.sh[1113]: Path=/var/lib/machines/container0
[   64.916354] TEST-13-NSPAWN.sh[1113]: Type=directory
[   64.917818] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   64.919127] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:15 UTC
[   64.921195] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   64.922736] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   64.924115] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   64.926028] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   64.929780] TEST-13-NSPAWN.sh[1113]: Name=container1
[   64.932270] TEST-13-NSPAWN.sh[1113]: Path=/var/lib/machines/container1
[   64.937198] TEST-13-NSPAWN.sh[1113]: Type=directory
[   64.939180] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   64.941253] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:17 UTC
[   64.944120] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   64.948628] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   64.952773] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   64.954895] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   64.956695] TEST-13-NSPAWN.sh[1113]: Name=container2
[   64.958277] TEST-13-NSPAWN.sh[1113]: Path=/var/lib/machines/container2
[   64.960335] TEST-13-NSPAWN.sh[1113]: Type=directory
[   64.962017] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   64.963740] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:19 UTC
[   64.966431] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   64.972945] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   64.990054] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   65.000323] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   65.002593] TEST-13-NSPAWN.sh[1113]: Name=container3
[   65.004688] TEST-13-NSPAWN.sh[1113]: Path=/var/lib/machines/container3
[   65.007159] TEST-13-NSPAWN.sh[1113]: Type=directory
[   65.009314] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   65.014598] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:20 UTC
[   65.017497] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   65.021623] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   65.024621] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   65.032846] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   65.035788] TEST-13-NSPAWN.sh[1113]: Name=container4
[   65.041296] TEST-13-NSPAWN.sh[1113]: Path=/var/lib/machines/container4
[   65.048934] TEST-13-NSPAWN.sh[1113]: Type=directory
[   65.053471] TEST-13-NSPAWN.sh[1113]: ReadOnly=no
[   65.058191] TEST-13-NSPAWN.sh[1113]: CreationTimestamp=Thu 2024-05-16 17:43:22 UTC
[   65.066216] TEST-13-NSPAWN.sh[1113]: Usage=18446744073709551615
[   65.069180] TEST-13-NSPAWN.sh[1113]: Limit=infinity
[   65.070656] TEST-13-NSPAWN.sh[1113]: UsageExclusive=18446744073709551615
[   65.073007] TEST-13-NSPAWN.sh[1113]: LimitExclusive=infinity
[   65.103778] TEST-13-NSPAWN.sh[568]: + machinectl clone container1 clone1
[   65.989440] TEST-13-NSPAWN.sh[568]: + machinectl show-image clone1
[   66.027592] TEST-13-NSPAWN.sh[1117]: Name=clone1
[   66.034330] TEST-13-NSPAWN.sh[1117]: Path=/var/lib/machines/clone1
[   66.042892] TEST-13-NSPAWN.sh[1117]: Type=subvolume
[   66.048925] TEST-13-NSPAWN.sh[1117]: ReadOnly=no
[   66.055071] TEST-13-NSPAWN.sh[1117]: CreationTimestamp=Thu 2024-05-16 17:44:00 UTC
[   66.062328] TEST-13-NSPAWN.sh[1117]: Usage=18446744073709551615
[   66.065121] TEST-13-NSPAWN.sh[1117]: Limit=infinity
[   66.067485] TEST-13-NSPAWN.sh[1117]: UsageExclusive=18446744073709551615
[   66.070401] TEST-13-NSPAWN.sh[1117]: LimitExclusive=infinity
[   66.102273] TEST-13-NSPAWN.sh[568]: + machinectl rename clone1 clone2
[   66.216406] TEST-13-NSPAWN.sh[1119]: + machinectl show-image clone1
[   66.434114] TEST-13-NSPAWN.sh[568]: + machinectl show-image clone2
[   66.634442] TEST-13-NSPAWN.sh[1122]: Name=clone2
[   66.635874] TEST-13-NSPAWN.sh[1122]: Path=/var/lib/machines/clone2
[   66.637970] TEST-13-NSPAWN.sh[1122]: Type=subvolume
[   66.639251] TEST-13-NSPAWN.sh[1122]: ReadOnly=no
[   66.640570] TEST-13-NSPAWN.sh[1122]: CreationTimestamp=Thu 2024-05-16 17:44:00 UTC
[   66.642616] TEST-13-NSPAWN.sh[1122]: Usage=18446744073709551615
[   66.644471] TEST-13-NSPAWN.sh[1122]: Limit=infinity
[   66.645929] TEST-13-NSPAWN.sh[1122]: UsageExclusive=18446744073709551615
[   66.647746] TEST-13-NSPAWN.sh[1122]: LimitExclusive=infinity
[   66.685861] TEST-13-NSPAWN.sh[568]: + lsattr -d /var/lib/machines
[   66.746455] TEST-13-NSPAWN.sh[1124]: ++ machinectl show-image --property=ReadOnly --value clone2
[   66.833404] TEST-13-NSPAWN.sh[568]: + [[ no == no ]]
[   66.837506] TEST-13-NSPAWN.sh[568]: + machinectl read-only clone2 yes
[   67.208582] TEST-13-NSPAWN.sh[1126]: ++ machinectl show-image --property=ReadOnly --value clone2
[   67.354985] TEST-13-NSPAWN.sh[568]: + [[ yes == yes ]]
[   67.356886] TEST-13-NSPAWN.sh[568]: + machinectl read-only clone2 no
[   67.655213] TEST-13-NSPAWN.sh[1128]: ++ machinectl show-image --property=ReadOnly --value clone2
[   67.946112] TEST-13-NSPAWN.sh[568]: + [[ yes == no ]]
[   67.947940] TEST-13-NSPAWN.sh[568]: + at_exit
[   67.953489] TEST-13-NSPAWN.sh[568]: + set +e
[   67.955203] TEST-13-NSPAWN.sh[568]: + machinectl status long-running
[   69.043397] TEST-13-NSPAWN.sh[568]: + machinectl kill --signal=KILL long-running
[   69.385074] TEST-13-NSPAWN.sh[568]: + mountpoint -q /var/lib/machines
[   69.387923] TEST-13-NSPAWN.sh[568]: + timeout 10 sh -c 'until umount /var/lib/machines; do sleep .5; done'
[   69.392923] TEST-13-NSPAWN.sh[568]: + [[ -n '' ]]
[   69.394724] TEST-13-NSPAWN.sh[568]: + rm -f '/run/systemd/nspawn/*.nspawn'
[   69.431197] TEST-13-NSPAWN.sh[506]: + echo 'Subtest /usr/lib/systemd/tests/testdata/units/TEST-13-NSPAWN.machinectl.sh failed'
[   69.441220] TEST-13-NSPAWN.sh[506]: Subtest /usr/lib/systemd/tests/testdata/units/TEST-13-NSPAWN.machinectl.sh failed
[   69.445805] TEST-13-NSPAWN.sh[506]: + return 1
[   92.723098] reboot: Power down
Finishing after writing 360010 entries
Test failed, relevant logs can be viewed with: 

gh run download 9115979814 --name ci-mkosi-9115979814-1-debian-testing-failed-test-journals -D ci/ci-mkosi-9115979814-1-debian-testing-failed-test-journals && journalctl --file ci/ci-mkosi-9115979814-1-debian-testing-failed-test-journals/test/journal/TEST-13-NSPAWN.journal --no-hostname -o short-monotonic -u TEST-13-NSPAWN.service -p info
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
@DaanDeMeyer DaanDeMeyer added the bug 🐛 Programming errors, that need preferential fixing label May 17, 2024
yuwata added a commit to yuwata/systemd that referenced this issue May 17, 2024
@yuwata
machine: cache found image when a dbus method in the main interface i…
0fba821 
…s called

Otherwise, if MarkImageReadOnly() is called for a image that is already
cached, Image.read_only flag of the cached object will never updated.

Fixes systemd#32888.
yuwata added a commit to yuwata/systemd that referenced this issue May 17, 2024
@yuwata
machine: cache found image when a dbus method in the main interface i…
09a1611 
…s called

Otherwise, if MarkImageReadOnly() is called for a image that is already
cached, Image.read_only flag of the cached object will never updated.

Fixes systemd#32888.
@yuwata yuwata mentioned this issue May 17, 2024
Merged
yuwata added a commit to yuwata/systemd that referenced this issue May 18, 2024
@yuwata
machine: cache found image when a dbus method in the main interface i…
0bad616 
…s called

Otherwise, if MarkImageReadOnly() is called for a image that is already
cached, Image.read_only flag of the cached object will never updated.

Fixes systemd#32888.
yuwata added a commit to yuwata/systemd that referenced this issue May 18, 2024
@yuwata
machine: cache found image when a dbus method in the main interface i…
c49e1c5 
…s called

Otherwise, if MarkImageReadOnly() is called for a image that is already
cached, Image.read_only flag of the cached object will never updated.

Fixes systemd#32888.
yuwata added a commit to yuwata/systemd that referenced this issue May 18, 2024
@yuwata
machine: also acquire Image object from cache when a dbus method in t…
ea21bfb 
…he main interface is called

Previously, Image objects were only cached when reading properties or
methods in the org.freedesktop.machine1.Image interface are called.

This makes that, when a method in the main interface (org.freedesktop.machine1)
for an image is called, also acquire the Image object from the cache,
and if not cached, create Image object and put into the cache, like we
do for org.freedesktop.machine1.Image.

Otherwise, if some properties of an image are updated by methods in the main
interface, e.g. MarkImageReadOnly(), the changes do not applied to the cached
Image object, and subsequent read of proerties through the interface for the
image, e.g. ReadOnly property, may provide outdated values.

Follow-up for 1ddb263.

Fixes systemd#32888.
yuwata added a commit to yuwata/systemd that referenced this issue May 19, 2024
@yuwata
machine: also acquire Image object from cache when a dbus method in t…
c6aeb9b 
…he main interface is called

Previously, Image objects were only cached when reading properties or
methods in the org.freedesktop.machine1.Image interface are called.

This makes that, when a method in the main interface (org.freedesktop.machine1)
for an image is called, also acquire the Image object from the cache,
and if not cached, create Image object and put into the cache, like we
do for org.freedesktop.machine1.Image.

Otherwise, if some properties of an image are updated by methods in the main
interface, e.g. MarkImageReadOnly(), the changes do not applied to the cached
Image object, and subsequent read of proerties through the interface for the
image, e.g. ReadOnly property, may provide outdated values.

Follow-up for 1ddb263.

Fixes systemd#32888.
mwilck pushed a commit to mwilck/systemd that referenced this issue May 28, 2024
@yuwata @keszybz
machine: also acquire Image object from cache when a dbus method in t…
bf270a3 
…he main interface is called

Previously, Image objects were only cached when reading properties or
methods in the org.freedesktop.machine1.Image interface are called.

This makes that, when a method in the main interface (org.freedesktop.machine1)
for an image is called, also acquire the Image object from the cache,
and if not cached, create Image object and put into the cache, like we
do for org.freedesktop.machine1.Image.

Otherwise, if some properties of an image are updated by methods in the main
interface, e.g. MarkImageReadOnly(), the changes do not applied to the cached
Image object, and subsequent read of proerties through the interface for the
image, e.g. ReadOnly property, may provide outdated values.

Follow-up for 1ddb263.

Fixes systemd#32888.

(cherry picked from commit c6aeb9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Programming errors, that need preferential fixing machine tests
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

several fixes for os image handling yuwata/systemd
2 participants
@DaanDeMeyer @yuwata