feat!: transliteration option for natural sorting #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clispios
force-pushed
the
feat/transliteration
branch
from
c6f0b4c
to
1ba2e8b
Compare
|
Thank you for the PR! Here's my change request: Since most characters are contiguous, representing them as Rust arrays could avoid parsing while providing lookup efficiency, as they are contiguous in memory: const DICT = [
"A", // À 192
"A", // Á 193
"A", // Â 194
// ...
"h", // ʯ 687
];I think they can be represented by 3 arrays, À (U+00C0) ~ ʯ (U+02AF): And, Ḅ (U+1E04 - 7684) ~ ỹ (U+1EF9 - 7929): fi (U+FB01 - 64257) ~ fl (U+FB02 - 64258): |
|
Very good point! Should be an easy enough change on my end. |
|
Please change it! |
|
I'll be able to finish the change request in the next day or two. Have not had enough free time the last week. Thanks! |
clispios
force-pushed
the
feat/transliteration
branch
from
1ba2e8b
to
84ed30e
Compare
|
Okay, change request is complete. Transliteration now uses 3 |
clispios
force-pushed
the
feat/transliteration
branch
from
84ed30e
to
7849712
Compare
|
Hi, I've made some simplifications and performance optimizations to the code and reviewed the |
sxyazi
approved these changes
May 26, 2024
sxyazi
changed the title
sxyazi
added a commit
that referenced
this pull request
May 26, 2024
Co-authored-by: sxyazi <sxyazi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #616.
To do this, I have a text file of transliteration mappings, which is then initialized into a static
HashMaponly once viaOnceLock. If we ever need more transliterations added, we just add to thetransliteration.mapfile. The actual transliteration is carried out via theTransliteratortrait, which is currently implemented on byte arrays.The user can set the
sort_transliterationconfig variables totrueif they would like to enable transliteration. They currently default tofalse. This will then apply transliteration to natural sorting only. We can extend transliteration to alphabetical sorting as well, but not sure if that is something you'd want.This also addresses some issues with the sorting keymap commands (they were all forcing
--dir-firstrather than pulling the value from the users config). Additionally, the--reverseparameter would persist as an override over the users config setting. I.e - If I setreverse = truein my config, and then I ran the,ncommand, it would set myreversevalue tofalsefor the rest of the session and disregard the value in my config.Here are some example screenshots (I know I still need to have some fun and make my theme better...) -
Natural sorting (without transliteration):
Natural sorting (with transliteration):
Please let me know your thoughts. Thanks!