Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the link to a table editor view for a table from a schema should select that schema #26389

Open
2 tasks done
paarthmadan opened this issue May 16, 2024 · 2 comments · May be fixed by #26595
Open
2 tasks done
Labels
bug Something isn't working frontend Related to supabase dashboard pr-opened A PR has been opened to resolve the issue

Comments

@paarthmadan
Copy link

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

When you open the link to a table that's not in the public schema in a new tab (ie. Cmd + Click or Ctrl + Click), the table editor shows the correct table contents but it doesn't change the schema accordingly, and therefore doesn't show it as selected in the left panel.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

Assume you have a project where:

  • There's more than 1 schema: ie. public and foo
  • And foo has table foo.table
  1. Change the schema dropdown to foo in the left panel.
  2. Open the table in a new tab, by selecting foo.table right-clicking "Open in new tab" or using Cmd/Ctrl + Click.
  3. Observe that the contents of the table grid are correct, but the schema is incorrect as it shows public.
  4. Observe that the selected table isn't present, because the list doesn't have the shown table.

Expected behavior

If you open the link https://supabase.com/dashboard/project/<project-id>/editor/<table-id> and table-id is a different schema than public, it should have that schema selected.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

  • OS: macOS
  • Browser: chrome
  • Version of supabase-js: not relevant
  • Version of Node.js: not relevant

Additional context

I can take this issue on, it seems pretty straightforward to fix. More or less have to update the selected schema for the TableEditorMenu if the table currently being viewed has a schema that doesn't align with the current selected schema.

@paarthmadan paarthmadan added the bug Something isn't working label May 16, 2024
@saltcod saltcod added the frontend Related to supabase dashboard label May 16, 2024
@Meyazhagan
Copy link

@paarthmadan Are you working on this fix, if not shall I do the fix?

@Hallidayo
Copy link
Contributor

Hi @Meyazhagan feel free to open a pull request for this issue 👍

@Meyazhagan Meyazhagan linked a pull request May 21, 2024 that will close this issue
@Hallidayo Hallidayo added the pr-opened A PR has been opened to resolve the issue label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to supabase dashboard pr-opened A PR has been opened to resolve the issue
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

4 participants