next-sitemap-1 #116
Open
next-sitemap-1 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
devilankur18
requested changes
Nov 30, 2023
apps/factory/next-sitemap.config.mjs
Outdated
Comment on lines
2
to
7
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
| const prisma = new PrismaClient({ | ||
| log: | ||
| process.env.NODE_ENV === "development" ? ["query", "error", "warn"] : ["error"], | ||
| }); | ||
|
|
There was a problem hiding this comment.
import prisma from db, no need to redefine it.
| }; | ||
| }); | ||
| } catch (error) { | ||
| console.error("Failed to fetch package data:", error); |
There was a problem hiding this comment.
use sentry to report exception
apps/factory/next-sitemap.config.mjs
Outdated
Comment on lines
10
to
20
| const packages = await prisma.promptPackage.findMany({ | ||
| where: { | ||
| visibility: PackageVisibility.PUBLIC, | ||
| }, | ||
| orderBy: { | ||
| updatedAt: "desc", | ||
| }, | ||
| include: { | ||
| User: true, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
create a common function and reuse it.
devilankur18
force-pushed
the
develop
branch
2 times, most recently
from
b4079f1
to
8642afc
Compare
devilankur18
force-pushed
the
develop
branch
2 times, most recently
from
760bc32
to
8d4361a
Compare
|
@LovedeepSingh19 use getServerSideProps to generate sitemaps on ondemand. https://nextjs.org/learn-pages-router/seo/crawling-and-indexing/xml-sitemaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic sitemap containing marketplace packages.