Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how st.write(st.beta_secrets) displays secrets #2905

Closed
astrojams1 opened this issue Mar 5, 2021 · 0 comments · Fixed by #8659
Closed

Update how st.write(st.beta_secrets) displays secrets #2905

astrojams1 opened this issue Mar 5, 2021 · 0 comments · Fixed by #8659
Labels
area:widgets type:enhancement Requests for feature enhancements or new features

Comments

@astrojams1
Copy link
Contributor

astrojams1 commented Mar 5, 2021

See image for current and desired

Screen Shot 2021-03-03 at 7 57 29 AM


Community voting on feature requests enables the Streamlit team to understand which features are most important to our users.

If you'd like the Streamlit team to prioritize this feature request, please use the 👍 (thumbs up emoji) reaction in response to the initial post.

@astrojams1 astrojams1 added type:enhancement Requests for feature enhancements or new features status:needs-triage Has not been triaged by the Streamlit team labels Mar 5, 2021
@kmcgrady kmcgrady removed the status:needs-triage Has not been triaged by the Streamlit team label Mar 9, 2021
@LukasMasuch LukasMasuch added the status:confirmed Bug has been confirmed by the Streamlit team label Jan 28, 2024
@jrieke jrieke removed the status:confirmed Bug has been confirmed by the Streamlit team label May 14, 2024
@snehankekre snehankekre added the status:in-progress We're on it! label May 14, 2024
snehankekre added a commit that referenced this issue Jun 4, 2024
## Describe your changes

When you call `st.write(st.secrets)`, the output is displayed as inline
code with `st.markdown`. This PR makes `st.write` call `st.json` on
objects of type `streamlit.runtime.secrets.Secrets`

## GitHub Issue Link (if applicable)

Closes #2905.

## Testing Plan

- Added Python unit test

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
@snehankekre snehankekre removed the status:in-progress We're on it! label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:widgets type:enhancement Requests for feature enhancements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants