Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version selector is not displayed correctly after enabling showing version alias #7187

Closed
3 of 4 tasks
raymond-u opened this issue May 16, 2024 · 4 comments
Closed
3 of 4 tasks
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@raymond-u
Copy link
Contributor

raymond-u commented May 16, 2024

Context

No response

Bug description

After upgrading to the latest version and enabling showing version alias, the version selector starts to displays some extra character.

Before:

image

Now:

image

Related part of mkdocs.yaml:

extra:
  version:
    provider: mike
    alias: true
    default:
      - nightly
      - stable

The command I use in GitHub Actions to deploy docs:

# Docs for nightly version
poetry run mike deploy --push nightly

# Docs for stable version
poetry run mike deploy --push --update-aliases ${{ steps.docs_version.outputs.docs_version }} stable
poetry run mike set-default --push stable

Related links

Reproduction

N/A

Steps to reproduce

N/A

Browser

Chrome

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. Unfortunately, without a minimal reproduction, it's unclear what is causing the problem. If you could at least share your versions.json that is built by mike, it would be a start.

@squidfunk squidfunk added bug Issue reports a bug needs reproduction Issue lacks a minimal reproduction .zip file labels May 16, 2024
@raymond-u
Copy link
Contributor Author

Apologies. Here is my version.json:

[
  {
    "version": "nightly",
    "title": "nightly",
    "aliases": []
  },
  {
    "version": "0.4",
    "title": "0.4",
    "aliases": [
      "stable"
    ]
  },
  {
    "version": "0.3",
    "title": "0.3",
    "aliases": []
  },
  {
    "version": "0.2",
    "title": "0.2",
    "aliases": []
  },
  {
    "version": "0.1",
    "title": "0.1",
    "aliases": []
  }
]

@squidfunk
Copy link
Owner

Thanks! Fixed in 407335d.

@squidfunk squidfunk added resolved Issue is resolved, yet unreleased if open and removed needs reproduction Issue lacks a minimal reproduction .zip file labels May 16, 2024
@squidfunk
Copy link
Owner

squidfunk commented May 20, 2024

Released as part of 9.5.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants