Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gateway MVC] ERR_HTTP2_PROTOCOL_ERROR if HTTP/2 enabled #3326

Open
benba opened this issue Mar 28, 2024 · 2 comments · May be fixed by #3369
Open

[Gateway MVC] ERR_HTTP2_PROTOCOL_ERROR if HTTP/2 enabled #3326

benba opened this issue Mar 28, 2024 · 2 comments · May be fixed by #3369
Labels
bug help wanted

Comments

@benba
Copy link

benba commented Mar 28, 2024 •
edited

if server.http2.enabled is set to true, using JDK HttpClient, and if the downstream server also exchange in HTTP/2, a HTTP/2 protocol error will be raised (ERR_HTTP2_PROTOCOL_ERROR in Chrome for example).

curl gives more details about the issue:
PROTOCOL_ERROR Invalid HTTP header filed was received: frame type: 1, stream: 1, name: [:status], value: [200]

An easy workardound is to add a HttpHeadersFilter.ResponseHttpHeadersFilter that removes the :status pseudo-header.

I can submit a PR if you feel that it's an appropriate fix
@spencergibb
Copy link
Member

PRs welcome

benba added a commit to benba/spring-cloud-gateway that referenced this issue Apr 22, 2024
@benba
Remove HTTP/2 :status pseudo header if added by downstream HTTP client.
5499e3f 
Fixes spring-cloudgh-3326.
benba added a commit to benba/spring-cloud-gateway that referenced this issue Apr 22, 2024
@benba
Remove HTTP/2 :status pseudo header if added by downstream HTTP client.
7d2f90a 
Fixes spring-cloudgh-3326.
benba added a commit to benba/spring-cloud-gateway that referenced this issue Apr 22, 2024
@benba
Remove HTTP/2 :status pseudo header if added by downstream HTTP client
310a620 
Fixes spring-cloudgh-3326
@benba benba linked a pull request Apr 22, 2024 that will close this issue
Open
@ebarliba
Copy link

For anyone stumbling upon this and looking for a workaround, I replaced the JDK HttpClient by adding Apache httpclient (org.apache.httpcomponents.client5:httpclient5) dependency and adding spring.cloud.gateway.mvc.http-client.type: autodetect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove HTTP/2 :status pseudo header if added by downstream HTTP client benba/spring-cloud-gateway
3 participants
@spencergibb @benba @ebarliba