Likely bug with anon state var

[zoffixznet]

Haven't run the code and just spotted this while reviewing some ecosystem code.

The {$++}" on this line needs to be changed to $($++)" or to " ~ $++:

spitsh/lib/Spit/Sh/Composer.pm6

Line 526 in 9bfc183

name => "eval_{$++}",

With original version, the state var is in its own block, which gets cloned when the outer block is entered, so the var ends up always being set to 1.

m: for ^3 { say "and {++$}"; }
rakudo-moar e9351cbaa: OUTPUT: «and 1␤and 1␤and 1␤»

m: for ^3 { say "and $(++$)"; }
rakudo-moar e9351cbaa: OUTPUT: «and 1␤and 2␤and 3␤»
m: for ^3 { say "and " ~ ++$; }
rakudo-moar e9351cbaa: OUTPUT: «and 1␤and 2␤and 3␤»

[zoffixznet]

Same issue on this line:

spitsh/lib/Spit/Parser/Actions.pm6

Line 1151 in 9bfc183

$*CU = SAST::CompUnit.new(name => "eval_{$++}", block => $new);