Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REWRITE PREVIEW] Need thoughts & feedback before releasing the update! #196

Open
snuffyDev opened this issue Sep 13, 2023 · 9 comments
Open

Comments

@snuffyDev
Copy link
Owner

https://preview.beatbump.io/home

Give it a try, let me know if things break. Let me know of any issues, if/how/when things break, and any comments or feedback!

AFAICT things are pretty smooth, but y'all can break it better than me (that's a compliment, thank you for it!)

@davidcollini
Copy link
Contributor

davidcollini commented Sep 13, 2023

It seems that the remember last track toggle in settings turns off after reloading

@davidcollini
Copy link
Contributor

trim.7C467A89-633A-4FAC-BAAE-032AC6A22AE1.MOV

There's two bugs here, one at that top of the main page and the second on the bottom of the full screen player

@snuffyDev
Copy link
Owner Author

@IronMaltese Good catches!!! Appreciate you testing it out so far!

@BrightDV
Copy link
Contributor

BrightDV commented Sep 13, 2023

Hi,
I just tried it, and the loading time seems really nice!
However, I found 'some' issues:

Mobile
  • The cross to close the search overlay is a bit off.
Database related – not sure whether those are really bugs
  • Adding a favorite throws the following exception:
    image
  • When creating a playlist, the page doesn't refresh
    Screencast.webm
  • Adding a song to a playlist doesn't save it neither, but there isn't a crash
    Screencast.webm
UI, not really bugs

(Immersive queue toggle is on)

  • I find that the animation when exiting the player is a bit too long, but that is more subjective.
  • Otherwise, the transition should be reversed when exiting the full screen player. For the moment, when you exit the player, the UI disappears and then the background disappears, whereas, when you open it, they both shows up at the time.
    Screencast.webm
Playback Updates URL setting – most buggy
  • I did not really understand how it works, because when enabling and then disabling the setting, the URL stills changes.
  • When enabled and clicking on the player, the URL correctly updates.
  • Then, if you skip the song using the button, the song played is some random song of the queue instead (between the 2nd and the 7th with my testing).
  • When exiting the player by clicking on it, the URL updates again with another URL (one of the song played before, not necessary in the queue).
  • Otherwise, the URL works well when opening it :)
Playback
  • The pause button does not work anymore, on both mobile and desktop.

@snuffyDev
Copy link
Owner Author

Appreciate the feedback, I'll iron these out!

@snuffyDev
Copy link
Owner Author

@IronMaltese fixed the second comment you left (the chips on the home page)

@BrightDV I fixed the refresh issue for playlists I believe. As for the other ones, I'm addressing them within the next couple days!

@snuffyDev
Copy link
Owner Author

Side note: working on a Spotify-like "multi-tab" feature

2023-09-14.17-28-52.mp4

@ghost
Copy link

ghost commented Sep 30, 2023

You forgot to add remove song from playlist button

@BrightDV
Copy link
Contributor

BrightDV commented Oct 3, 2023

I just found that the explicit symbol is always shown in the album view.
For example, an album of Bach is shown as explicit... (without any explicit track).
image

I double-checked on YouTube Music, and it is not shown as explicit. I guess that the icon is always shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants