Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel version and compatibility number out of sync #1141

Open
zaucy opened this issue Apr 29, 2024 · 4 comments · May be fixed by #1147
Open

bazel version and compatibility number out of sync #1141

zaucy opened this issue Apr 29, 2024 · 4 comments · May be fixed by #1147
Assignees
Labels
build system requests or issues related to the build system

Comments

@zaucy
Copy link
Contributor

zaucy commented Apr 29, 2024

The current release process doesn't increment the version or compatibility level in the MODULE.bazel file. I've recently submitted EnTT to the BCR and had to patch it in (so no worries there.)

I'm creating this issue for visibility sake, but I plan on creating a PR to fix this myself in the coming weeks.

edit:

bazelbuild/bazel-central-registry#1904 (comment)

The current advice is to avoid compatibility_level altogether so it would probably be best to omit it for now until EnTT introduces some major breaking changes.

@skypjack skypjack self-assigned this Apr 30, 2024
@skypjack skypjack added the build system requests or issues related to the build system label Apr 30, 2024
@skypjack
Copy link
Owner

@zaucy can I close this issue?

@zaucy zaucy linked a pull request May 30, 2024 that will close this issue
@zaucy
Copy link
Contributor Author

zaucy commented May 30, 2024

thanks for the reminder! with #1147 it can be.

@zaucy
Copy link
Contributor Author

zaucy commented May 30, 2024

although the version number is still not automatically updated. Is there a release script I could update?

Typically I would update the version via buildozer like so:

buildozer "set version $VERSION" //MODULE.bazel:%module

I'm willing to put in the work. How do you typically update the version of things like ENTT_VERSION_MINOR? Is it a manual process?

@skypjack
Copy link
Owner

I usually update version.h, then I read it from cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system requests or issues related to the build system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants