Provide feature to have prepared shimmer layout #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add separate activities in demo app, each demonstrates one type of recyclerview
add toolbar navigation and better FAB UI add "isPrepared" to attrs
skydoves
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Hey @avalanchas, this is very impressive and well-refactored across overall architecture!
I do love this PR 鉂わ笍 I really appreciate your huge contribution! It must be very helpful to these library users.
|
Hi @skydoves, thank you for the high praise, coming from you it means a lot! I have one more note though: as I mentioned above:
In my humble opinion I think we should reopen #15 until carousels can be auto-masked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds very simple functionality to give a
VeilLayout(and thus by extension aVeilRecyclerFrameView) a pre-made (prepared by the caller ahead of time)ShimmerFrameLayoutto show when veiled. This simply means that the custom "masking" process is skipped and the VeilLayout simply shows the defaultChild view - which, again, is already shimmeringThis means that the caller can just as well insert a Shimmer Layout for a carousel item, thereby going the first steps towards fixing #15 馃帀
Personally, I would not close #15 yet, because in a perfect world AndroidVeil would auto-mask a carousel layout as well
A demo activity for a shimmering carousel is included in this PR
Types of changes
What types of changes does your code introduce?
This PR is fully compatible with previous versions because we simply assume
isPrepared = falsein all places, named parameters and xml attrs. Thus, the behaviour of existing apps does not change, only whenisPreparedis set totruewill the code stop adding the maskedshimmerContainerPreparing a pull request for review