Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] keras/transformers installation error on python 3.8-3.11 in CI #6445

Closed
fkiraly opened this issue May 18, 2024 · 2 comments · Fixed by #6447
Closed

[MNT] keras/transformers installation error on python 3.8-3.11 in CI #6445

fkiraly opened this issue May 18, 2024 · 2 comments · Fixed by #6447
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 18, 2024

It seems that keras and transformers have some incompatibiliy and fail with installation on 3.11 CI and lower.

Example: https://github.com/sktime/sktime/actions/runs/9134142708/job/25119213085?pr=6442

I suppose it has to do with a recent release?

FYI @benHeid
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label May 18, 2024
@benHeid
Copy link
Contributor

benHeid commented May 18, 2024

Transformers is not supporting Keras 3. It seems that a new check was added in the transformers version that was released yesterday.

However, I am bit confused why Keras is installed if transformers is installed even if there is a version specified.

For now, I would propose to pin the version of transformers to < 4.41.0

@fkiraly
Copy link
Collaborator Author

fkiraly commented May 18, 2024

For now, I would propose to pin the version of transformers to < 4.41.0

ok - PR?

@fkiraly fkiraly mentioned this issue May 18, 2024
Merged
fkiraly added a commit that referenced this issue May 19, 2024
@fkiraly
[MNT] bound transformers<4.41.0 (#6447)
5098ebe 
Carries out @benHeid's suggestion to fix #6445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MNT] bound transformers<4.41.0 sktime/sktime
2 participants
@fkiraly @benHeid