Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still accepting new entries? #1323

Closed
aschrijver opened this issue Jun 3, 2018 · 9 comments
Closed

Still accepting new entries? #1323

aschrijver opened this issue Jun 3, 2018 · 9 comments

Comments

@aschrijver
Copy link
Contributor

Looking at closed PR's the last merged addition dates back from October 2017 with now 135 PR's pending..

Are you still accepting new entries?

@koppor
Copy link

koppor commented Jun 4, 2018

Refs #784, #732, and somehow #550.

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 4, 2018

I'm still accepting new entries. I've just been too burned out to review entries. I have a clear set of guidelines and nobody seems to read them. It feels like a lot of new lists are just quickly put together in the hope of popularity without putting much thought towards quality. I rather not merge than merge less than awesome stuff. If you want to see more lists merged, I could use help reviewing them :)

@aschrijver
Copy link
Contributor Author

That is understandable. Thank you for your response! I'll see if I can put in some time now and then to review open cases, and if everyone does that, make your task lighter :)

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 5, 2018

I'm also considering adding a new submission requirement: "You have to review 2 other pull requests before getting a review". I think that could be a good way to partly self-sustain the process.

@aschrijver
Copy link
Contributor Author

aschrijver commented Jun 5, 2018

That is a good idea @sindresorhus !

I just reviewed a number of PR's that did not have comments yet (none passed quality control). I found one thing that may be added to the guidelines for the top-level list:

  • A description should not contain additional hyperlinks

@davisonio
Copy link
Contributor

I love this project so much and I've found so many good resources from it. I'll see if I can go through some of these PRs.

@taggie05
Copy link

@sindresorhus I have you considered adding collaborators to help you out so that managing PR requests in order to clear some of the backlog?

@sindresorhus
Copy link
Owner

I tried that many times. There’s nothing stopping people from helping out reviewing pull requests even without collaborator status.

@sindresorhus
Copy link
Owner

Closing in favor of #1363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants