Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded Gateway URL #51

Open
kawaii opened this issue Aug 19, 2020 · 0 comments
Open

Hardcoded Gateway URL #51

kawaii opened this issue Aug 19, 2020 · 0 comments
Assignees

Comments

@kawaii
Copy link
Member

kawaii commented Aug 19, 2020

Currently, we hardcode the gateway URL like so;

#| Host to which to connect. Can be overridden for testing e.g.
has Str $.ws-host = 'gateway.discord.gg';

According to the documentation this behaviour is wrong. and in actuality we should be calling the Get Gateway or Get Gateway Bot endpoints for this information.

https://discord.com/developers/docs/topics/gateway#connecting-gateway-url-params

https://discord.com/developers/docs/topics/gateway#get-gateway
https://discord.com/developers/docs/topics/gateway#get-gateway-bot

I think it's still useful to be able to override the gateway URL, so we should keep that in mind when refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants