-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segement downloaded in 5 ms, wrong information #6623
Comments
additionally we are only passing information of the bandwidth during the on-progress and never at the end of the download of the segment. I'm wondering if we should also add it when the download is ended. event if it's kind of duplicate here the end of the request shaka-player/lib/net/networking_engine.js Line 577 in 4a41a9a
here the way it's calculated in the on progress |
Browser caching could explain bad data being fed to ABR manager. Can you try again with caching disabled/cleared in your browser? |
@joeyparrish sorry i should mention this but the test had been done with cache disable on FF |
We should use something like https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/models/ThroughputModel.js#L250 Since I want to make improvements to the ABR, I assign it to myself and move to improvement. |
@avelad that is lovely i was pushing the same PR you were too fast !!!! thanks |
Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
If the question is related to FairPlay, have you read the tutorial?
N/A
What version of Shaka Player are you using?
Latest
What browser and OS are you using?
Firefox
Please ask your question
When i looked to how the player is behaving against bandwidth changed i found that the network engine was sending wired information to the ABR manager
Segment downloaded: contentType=video deltaTimeMs=5 numBytes=132328 lastTimeChosenMs=1715701213390 enabled=true
Segment downloaded: contentType=video deltaTimeMs=153 numBytes=71224 lastTimeChosenMs=1715701213390 enabled=true
Segment downloaded: contentType=video deltaTimeMs=604
deltaTimeMs=5 so much data in so short time is quite wired to me. is that something possible can it be linked to wrong information.
have you experience it ?
Should we put some filter to avoid to count that value inside the ABR manager
The text was updated successfully, but these errors were encountered: