Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change verification key points in contract to constant #330

Open
saleel opened this issue Jun 1, 2023 · 0 comments
Open

Change verification key points in contract to constant #330

saleel opened this issue Jun 1, 2023 · 0 comments
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new

Comments

@saleel
Copy link
Contributor

saleel commented Jun 1, 2023

The VK_POINTS points variable storing the verification key points in the contract is not a constant.

The value will be stored in storage slots and would require reading every time. If this could be changed to a constant, the value will be part of the bytecode and verification will be cheaper (and also better performance I think).

Since this is an array it cannot be marked as constant directly, so other techniques need to be explored.

@saleel saleel added the feature 🚀 This is enhancing something existing or creating something new label Jun 1, 2023
@saleel saleel self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
None yet
Development

No branches or pull requests

1 participant