Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_compacting_data_for_streaming_and_repair has to be LiveUpdate #18674

Open
denesb opened this issue May 14, 2024 · 0 comments · May be fixed by #18705
Open

enable_compacting_data_for_streaming_and_repair has to be LiveUpdate #18674

denesb opened this issue May 14, 2024 · 0 comments · May be fixed by #18705
Assignees
Labels
backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0
Milestone

Comments

@denesb
Copy link
Contributor

denesb commented May 14, 2024

In theory it is, but when propagated down to the table object, the LiveUpdate property is lost (database.cc):

1251     cfg.enable_compacting_data_for_streaming_and_repair = db_config.enable_compacting_data_for_streaming_and_repair();

Here, we use named_value<T>::operator(), which casts the utils::updateable_value<T> to const T& and hence the update signal chain is broken. table::config::enable_compacting_data_for_streaming_and_repair is bound to a constant and will not receive updates on the config item.

@denesb denesb added backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0 labels May 14, 2024
@denesb denesb self-assigned this May 14, 2024
@denesb denesb added this to the 6.1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant