mutation_fragment_stream_validating_filter doesn't respect validation_level::none
#18662
Assignees
Labels
Backport candidate
backport/5.2
Issues that should be backported to 5.2 branch once they'll be fixed
backport/5.4
Issues that should be backported to 5.4 branch once they'll be fixed
backport/6.0
Field-Tier1
Urgent issues as per FieldEngineering request
Milestone
Comments
denesb
added
backport/5.2
This was referenced May 17, 2024
Merged
denesb
added a commit
that referenced
this issue
May 20, 2024
…pect validating_level::none' from ScyllaDB Even when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to. Fixes: #18662 (cherry picked from commit f6511ca) (cherry picked from commit e7b0769) (cherry picked from commit 78afb36) Refs #18667 Closes #18724 * github.com:scylladb/scylladb: test/boost/mutation_fragment_test.cc: add test for validator validation levels mutation: mutation_fragment_stream_validating_filter: fix validation_level::none mutation: mutation_fragment_stream_validating_filter: add raises_error ctor parameter
denesb
added a commit
that referenced
this issue
May 27, 2024
…pect validating_level::none' from ScyllaDB Even when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to. Fixes: #18662 (cherry picked from commit f6511ca) (cherry picked from commit e7b0769) (cherry picked from commit 78afb36) Refs #18667 Closes #18723 * github.com:scylladb/scylladb: test/boost/mutation_fragment_test.cc: add test for validator validation levels mutation: mutation_fragment_stream_validating_filter: fix validation_level::none mutation: mutation_fragment_stream_validating_filter: add raises_error ctor parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some validation is still done but if some error is detected, there are no details printed, because the details (partition key, clustering key) are not saved due to the validation level.
Disable the validation completely when the validator was configured with
validation_level::none.The text was updated successfully, but these errors were encountered: