Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pairdrop user gets offline while still choosing files to send #247

Open
svl168 opened this issue Jan 21, 2024 · 4 comments · May be fixed by #267
Open

[Bug] Pairdrop user gets offline while still choosing files to send #247

svl168 opened this issue Jan 21, 2024 · 4 comments · May be fixed by #267
Labels
bug Something isn't working under development

Comments

@svl168
Copy link

svl168 commented Jan 21, 2024

Pairdrop user gets offline while still choosing files to send or still taking picture to send.

To Reproduce

  1. 2 users (ex. Adam and Eve) using each other's mobile data and running pairdrop at the same time in a chrome browser of their android phone. Both have previously been paired. and names were permanently named already
  2. Adam saw Eve in his pairdrop and clicked her icon in an attempt to send a picture in his gallery
  3. Few seconds have passed like even just 3 seconds after, Eve noticed Adam disappeared already like offline.
  4. After Adam has chosen a picture to send and clicked send or OK, Eve disappeared already. so, have to repeat again and have to be very fast this time around to avoid getting offline.
  5. This does not happen if you're in same WIFI network or at least I did not notice it happen yet.

Expected behavior
online status should stay online (each other's icon) while one of them is still choosing files to send or taking pictures.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Samsung S23 Ultra
  • OS: android 14 one ui 6
  • Browser chrome or brave
  • Version latest

Bug occurs on official PairDrop instance https://pairdrop.net/
Yes
Version: v1.10.5

Bug occurs on self-hosted PairDrop instance
No | Yes

Additional context
Add any other context about the problem here.

@svl168 svl168 added the bug Something isn't working label Jan 21, 2024
@schlagmichdoch
Copy link
Owner

The server checks periodically if a client is still online. The problem might be that the JavaScript code in the browser is stopped by some browsers when their file selector is opened.

online status should stay online (each other's icon) while one of them is still choosing files to send or taking pictures.

Maybe it'd be more stable if the server stopped as long as a file selector is open. Maybe it would also be sufficient to increase the timeout period.

Is the issue consistently reproducible?

@svl168
Copy link
Author

svl168 commented Jan 22, 2024

Yes, reproducible all the time. Take note, occurs too while taking a picture. Please make the timeout be at least 20 seconds. Thanks for responding.

Other than that, your program is just perfect.

schlagmichdoch added a commit that referenced this issue Feb 6, 2024
…and auto resume of transfer + sending of queued messages. (fixes #260 and #247)
@schlagmichdoch schlagmichdoch linked a pull request Feb 9, 2024 that will close this issue
42 tasks
@schlagmichdoch
Copy link
Owner

I have finally implemented this! 🎉

I'd appreciate it if you could test whether your issue is resolved on the development instance here: https://pairdrop-dev.onrender.com

@schlagmichdoch
Copy link
Owner

As the repository was falsely flagged and hidden for the last month this probably never reached you so this is a friendly bump.

@svl168 I would appreciate it, if you could test this feature on the instance above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working under development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants