[Bug] Non-unique indexes in PostgreSQL are not generated

[ostefano]

I am using schemahero 0.17.2 and PostgreSql and I see issues when using single column indexes that are not unique.

For example, this works and creates two indexes.

indexes:
- columns:
  - elem_id
  - feature_id
  name: idx_elem_feature
  isUnique: true
- columns:
  - feature_id
  name: idx_feature_id
  isUnique: true

While this one does not, and the second index is not generated:

indexes:
- columns:
  - elem_id
  - feature_id
  name: idx_elem_feature
  isUnique: true
- columns:
  - feature_id
  name: idx_feature_id
  isUnique: false

[rubenhak]

We are also experiencing this. Looks like the decision making regarding indexes happens here, but couldn't find any mention of isUnique though...

schemahero/pkg/database/postgres/deploy.go

Line 286 in 87ad5be

func BuildIndexStatements(p *PostgresConnection, tableName string, postgresTableSchema *schemasv1alpha4.PostgresqlTableSchema) ([]string, error) {

[rubenhak]

Or is this if index.IsUnique causing the issue?

schemahero/pkg/database/postgres/create.go

Line 66 in 87ad5be

if index.IsUnique {

[Phat3]

Possible fix #1071