Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xplr crashes if terminal has <= 94 columns #718

Open
abhinavnatarajan opened this issue May 18, 2024 · 5 comments
Open

xplr crashes if terminal has <= 94 columns #718

abhinavnatarajan opened this issue May 18, 2024 · 5 comments

Comments

@abhinavnatarajan
Copy link
Contributor

There is a particular folder on my computer, that if I open up in xplr, will cause a crash if the terminal window has 94 or fewer columns.
This does not happen when the number of columns is greater than or equal or 95.

I am running wezterm (20240203-110809-5046fc22). In both previews below, I try to open the folder named 'homological_algebra' using xplr.

xplr.bug.mp4
xplr.bug.2.mp4
@sayanarijit
Copy link
Owner

Very interesting. Could be a ratatui issue. Not sure. Is there a file with a very long name?

@abhinavnatarajan
Copy link
Contributor Author

Not really, all the file names are at most 30 characters. The issue is likely an upstream bug in ratatui, and the fix has not yet made its way to a release. I will try building with the latest nightly version of ratatui to check if the issue persists.

@abhinavnatarajan
Copy link
Contributor Author

I can confirm that the issue is resolved when using the latest commit of ratatui, so perhaps this issue can be closed when they next release.

@sayanarijit
Copy link
Owner

Let’s keep it open till the next release, so that others can see this.

@abhinavnatarajan
Copy link
Contributor Author

ratatui v0.26.3 has been released and contains the relevant fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants