Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No bookmark-menu-heading in Emacs 29.0.91 #147

Open
tuhdo opened this issue Jun 9, 2023 · 4 comments
Open

No bookmark-menu-heading in Emacs 29.0.91 #147

tuhdo opened this issue Jun 9, 2023 · 4 comments

Comments

@tuhdo
Copy link

tuhdo commented Jun 9, 2023

Here is the stack trace:

Debugger entered--Lisp error: (error "Invalid face" bookmark-menu-heading)
  set-face-attribute(bookmark-menu-heading nil :foreground unspecified :background unspecified :family unspecified :slant unspecified :weight unspecified :height unspecified :underline unspecified :overline unspecified :box unspecified :inherit nano-face-strong)
  set-face(bookmark-menu-heading nano-face-strong)
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_4>()
  eval-after-load-helper("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  do-after-load-evaluation("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  require(bookmark)
  eval-expression((require 'bookmark) nil nil 127)
  funcall-interactively(eval-expression (require 'bookmark) nil nil 127)
  command-execute(eval-expression)

@rougier
Copy link
Owner

rougier commented Jun 19, 2023

Can you try to add (require 'bookmark)?

@tuhdo
Copy link
Author

tuhdo commented Jun 20, 2023

(require 'bookmark) produced the same error:

Debugger entered--Lisp error: (error "Invalid face" bookmark-menu-heading)
  set-face-attribute(bookmark-menu-heading nil :foreground unspecified :background unspecified :family unspecified :slant unspecified :weight unspecified :height unspecified :underline unspecified :overline unspecified :box unspecified :inherit nano-face-strong)
  set-face(bookmark-menu-heading nano-face-strong)
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_4>()
  eval-after-load-helper("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  do-after-load-evaluation("f:/emacs/share/emacs/29.0.91/lisp/bookmark.elc")
  require(bookmark)
  eval-expression((require 'bookmark) nil nil 127)
  funcall-interactively(eval-expression (require 'bookmark) nil nil 127)
  command-execute(eval-expression)

I loaded bookmark just before (use-package nano). Without loading bookmark, then there's no error but as soon as I tried to use any bookmark commands, Emacs throws that error.

@rougier
Copy link
Owner

rougier commented Jul 17, 2023

Can you try with latest version? think bookmark has been fixed.

@tuhdo
Copy link
Author

tuhdo commented Nov 2, 2023

@rougier it didn't solve the problem. In the end, I made a workaround by defining the face so NANO won't complain.

Anyway, I finally can integrate NANO with my config and make it look as intended on Windows, which I did not succeed in previous attempts. I made a thread on Reddit if you are curious on how it looks like: https://www.reddit.com/r/emacs/comments/17m8vwq/guide_setup_nano_emacs_theme_properly_on_windows/

Thanks for this great piece of software that really improves my user experience with Emacs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants