Added confirmation for opengb init command
#279
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @NathanFlurry I have implemented the solution as discussed. I would appreciate it if you could review it at your earliest convenience. Please let me know if you have any questions or require further clarification. Thank you. |
NathanFlurry
requested changes
May 18, 2024
There was a problem hiding this comment.
welcome, thanks for the pr!
using this in practice, i don't think it actually makes sense to print the files. would simplify intro to something like:
Project created successfully
Created config file at backend.yaml
Get started at https://opengb.dev/introduction
|
@NathanFlurry I have made the required changes. |
NathanFlurry
approved these changes
May 25, 2024
|
@vr-varad thanks for the pr! apologies for the ticket being wrong, i pushed some small tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
Say which files were created
Link to docs on getting started
solution Implementation
The
templateProjectfunction now returns a Promise of typestring[], tracking the paths of created files and directories and resolving with this array. Error handling is implemented to catch and log errors, returning an empty array if creation fails.Resolves #277